Quick drive-by comment...

https://chromiumcodereview.appspot.com/11528003/diff/2001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://chromiumcodereview.appspot.com/11528003/diff/2001/src/arm/macro-assembler-arm.h#newcode111
src/arm/macro-assembler-arm.h:111: void IterateCompiledFrame(const
StandardFrame* frame, ObjectVisitor* v);
Shouldn't this be a method of StandardFrame? A naked top-level function
always looks a bit suspicious in an OO world...

Same for other platforms.

https://chromiumcodereview.appspot.com/11528003/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to