https://codereview.chromium.org/11416238/diff/10002/src/elements.cc File src/elements.cc (right):
https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1005 src/elements.cc:1005: static ElementsKind ElementsKindForArray(FixedArrayBase* array) { On 2012/12/11 17:07:04, danno wrote:
Not sure how performance sensitive this is, but how about forcing this
to
inline, too?
Done. https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1014 src/elements.cc:1014: return FAST_HOLEY_DOUBLE_ELEMENTS; The problem is that this switches over instances types. There are very many of those, so most aren't handled here. We could shift and only look at the window of used types, but even those are not consecutive (at least FIXED_ARRAY_TYPE isn't in the same range as the others). On 2012/12/11 17:07:04, danno wrote:
How about a lookup array instead of the switch for the
FIXED_ARRAY_TYPE case.
Again, not sure if this is super performance critical, but it could be
for
copies of small site.
https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1079 src/elements.cc:1079: // This case should be UNREACHABLE(). Indeed. This should be cleaned up sometime; but that's unrelated to this CL... On 2012/12/11 17:07:04, danno wrote:
Yikes, this is totally scary.
https://codereview.chromium.org/11416238/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
