On 2012/12/17 18:46:55, palfia wrote:
Thanks for the review, I've addressed your comments and I've also cleaned up
the
code a bit.
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc File src/mips/codegen-mips.cc (right):
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newcode550
src/mips/codegen-mips.cc:550: // Smis are tagged by left shift by 1, thus LSR
by
1 to smi-untag inline. On 2012/12/17 10:27:26, Yang wrote: > This comment does not apply to MIPS.
Done.
https://codereview.chromium.org/11573017/diff/1/src/mips/codegen-mips.cc#newcode551
src/mips/codegen-mips.cc:551: __ srl(at, index, 1); On 2012/12/17 10:27:26, Yang wrote: > Isn't there a SmiUntag macro for MIPS as well?
Done.
LGTM, landing. https://codereview.chromium.org/11573017/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
