LGTM. Will land with comments fixed.
https://codereview.chromium.org/11649018/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11649018/diff/1/src/objects.cc#newcode7901 src/objects.cc:7901: utf16_length += is_two_byte ? 2 : 1; is_two_byte is a misnomer? https://codereview.chromium.org/11649018/diff/1/src/unicode-inl.h File src/unicode-inl.h (right): https://codereview.chromium.org/11649018/diff/1/src/unicode-inl.h#newcode282 src/unicode-inl.h:282: return length; no line break here. https://codereview.chromium.org/11649018/diff/1/src/unicode.cc File src/unicode.cc (right): https://codereview.chromium.org/11649018/diff/1/src/unicode.cc#newcode330 src/unicode.cc:330: if (is_two_byte) { misnomer? https://codereview.chromium.org/11649018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
