Although slight, I do see the improvement in Kraken crypto. Landing with
fixed
nits.
https://codereview.chromium.org/11316105/diff/15001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/11316105/diff/15001/src/arm/code-stubs-arm.cc#newcode2444
src/arm/code-stubs-arm.cc:2444: case Token::DIV: {
nit: indentation
https://codereview.chromium.org/11316105/diff/15001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/11316105/diff/15001/src/arm/lithium-arm.cc#newcode1272
src/arm/lithium-arm.cc:1272: LOperand* divisor =
CpuFeatures::IsSupported(SUDIV) ? UseRegister(right)
nit: indentation. For 80+col conditional operator statements, formatting
should be of form:
<condition>
? <value_true>
: <value_false>;
https://codereview.chromium.org/11316105/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
