Feedback addressed, landing...
https://codereview.chromium.org/12033011/diff/6001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/12033011/diff/6001/include/v8.h#newcode397
include/v8.h:397: V8_INLINE(static Persistent<T> New(Handle<T> that));
On 2013/01/24 13:09:05, Michael Starzinger wrote:
Should this be marked deprecated?
Done.
https://codereview.chromium.org/12033011/diff/6001/include/v8.h#newcode466
include/v8.h:466: V8_INLINE(bool IsNearDeath() const);
On 2013/01/24 13:09:05, Michael Starzinger wrote:
Should this be marked deprecated?
Done.
https://codereview.chromium.org/12033011/diff/6001/include/v8.h#newcode478
include/v8.h:478: V8_INLINE(void SetWrapperClassId(uint16_t class_id));
On 2013/01/24 13:09:05, Michael Starzinger wrote:
Should this be marked deprecated?
Done.
https://codereview.chromium.org/12033011/diff/6001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/12033011/diff/6001/src/global-handles.cc#newcode473
src/global-handles.cc:473: NearDeathCallback near_death_callback) {
On 2013/01/24 13:09:05, Michael Starzinger wrote:
Add an assertion similar to the following:
ASSERT((weak_reference_callback != NULL) !=
(near_death_callback != NULL));
Done.
https://codereview.chromium.org/12033011/diff/6001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/12033011/diff/6001/test/cctest/test-api.cc#newcode5519
test/cctest/test-api.cc:5519: prev.MakeWeak(isolate, new Snorkel(),
&HandleWeakReference);
On 2013/01/24 13:09:05, Michael Starzinger wrote:
Can we use info.GetIsolate() here?
Done.
https://codereview.chromium.org/12033011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
