I don't feel too strongly about this, but I'd prefer not omitting "string"
from
"internalized string", for example in StringShape::IsInternalized,
kIsInternalizedMask and kIsInternalizedTag.
Missing renames in:
- v8-counters.h
- ast.h (comments)
- v8.h and api.cc, but I guess there is not much we can do without changing
the
API
- d8.cc
- json-parser.h
I don't think gdb-jit.cc needs to be changed as the notion of symbol there
is
not in V8's context.
https://codereview.chromium.org/12210083/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/12210083/diff/1/src/arm/code-stubs-arm.cc#newcode1750
src/arm/code-stubs-arm.cc:1750: // We could be strict about
internalized/string here, but as long as
suggest to change to "... about internatilized/non-internalized string
here..."
https://codereview.chromium.org/12210083/diff/1/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):
https://codereview.chromium.org/12210083/diff/1/src/arm/ic-arm.cc#newcode1076
src/arm/ic-arm.cc:1076:
isolate->counters()->keyed_load_generic_symbol(), 1, r2, r3);
forgot to change this?
https://codereview.chromium.org/12210083/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/12210083/diff/1/src/bootstrapper.cc#newcode1393
src/bootstrapper.cc:1393:
factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR(name));
\
You could re-align this new-line escape :)
https://codereview.chromium.org/12210083/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):
https://codereview.chromium.org/12210083/diff/1/src/gdb-jit.cc#newcode855
src/gdb-jit.cc:855: class ELFStringTable : public ELFSection {
I was thinking that this use of "symbol" has nothing to do with V8...
and you didn't change the ELFSymbol class, so changing this here makes
little sense.
https://codereview.chromium.org/12210083/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/12210083/diff/1/src/objects.h#newcode410
src/objects.h:410: V(EXTERNAL_INTERNALIZED_STRING_TYPE,
\
sort of funny... :)
https://codereview.chromium.org/12210083/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
