On 2013/02/21 09:00:30, Yury Semikhatsky wrote:
I like that we can test this issue but how can we prove that the test won't
flake?


I have no data about that but for 10k objects the reuse counter is ~4k.
I'll fix the flakiness if it happens.


https://chromiumcodereview.appspot.com/12321042/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):


https://chromiumcodereview.appspot.com/12321042/diff/1/test/cctest/test-heap-profiler.cc#newcode397
test/cctest/test-heap-profiler.cc:397: // FIXME: We have problem with address
reuse.
"Object ids should be unique but it is not so at the moment."

done

https://chromiumcodereview.appspot.com/12321042/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to