Reviewers: Yury Semikhatsky, alph, Yang,
Message:
On 2013/02/21 09:07:44, Yury Semikhatsky wrote:
https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/12314027/diff/1/src/heap-snapshot-generator.cc#newcode32
src/heap-snapshot-generator.cc:32: #include "heap-profiler.h"
It is already included in "heap-snapshot-generator-inl.h"
I'll fix that
https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/12314027/diff/1/src/profile-generator.h#newcode64
src/profile-generator.h:64: class StringsStorage {
StringStorage is used by both cpu profile and heap snapshot generators.
Should
we move it into something like profile-generator-common.h?
I'll do that in a separate patch.
Description:
Split profile-generator
CPU profile code and Heap Snapshot code are completely unrelated to each
other.
So we can extract heap snapshot part into separate file.
No functional changes.
BUG=none
TEST=none
Please review this at https://codereview.chromium.org/12314027/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/SConscript
M src/api.cc
M src/heap-profiler.cc
A + src/heap-snapshot-generator-inl.h
A + src/heap-snapshot-generator.h
A + src/heap-snapshot-generator.cc
M src/profile-generator-inl.h
M src/profile-generator.h
M src/profile-generator.cc
M src/v8.h
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
