On 2013/02/21 15:26:43, Yury Semikhatsky wrote:
https://codereview.chromium.org/12320039/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/12320039/diff/1/src/heap-snapshot-generator.cc#newcode402
src/heap-snapshot-generator.cc:402: void
HeapObjectsMap::MoveObject(Address
from, Address to) {
Is it possible that an object is allocated (not moved) directly at an
address
of
already tracked object?
As far as I know it is possible but it is another case.
https://codereview.chromium.org/12320039/diff/1/src/heap-snapshot-generator.cc#newcode408
src/heap-snapshot-generator.cc:408: // We don't know the object that may
occupy
the place of a known object.
I'd rephrase like this:
"It may occur that some untracked object moves to an address X and there
is a
tracked object at that address. In this case we should remove the entry
as we
know that the object has died."
done
https://codereview.chromium.org/12320039/diff/1/src/heap-snapshot-generator.cc#newcode419
src/heap-snapshot-generator.cc:419: // We found the entry with to address
for
an
old object.
the entry -> existing entry
done
https://codereview.chromium.org/12320039/diff/1/src/heap-snapshot-generator.cc#newcode430
src/heap-snapshot-generator.cc:430: to_entry->value =
reinterpret_cast<void*>(from_entry_info_index);
to_entry->value = from_value; ?
done
https://codereview.chromium.org/12320039/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
