LGTM with a bunch of nits.
https://codereview.chromium.org/12300018/diff/139/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/code-stubs.cc#newcode311
src/code-stubs.cc:311: String* symbol = strict() ?
Drop one of the two white-spaces on the left-hand side.
https://codereview.chromium.org/12300018/diff/139/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/debug.cc#newcode1304
src/debug.cc:1304: function->GetIsolate());
Better use "isolate_" here.
https://codereview.chromium.org/12300018/diff/139/src/debug.cc#newcode2961
src/debug.cc:2961: fun->GetIsolate()),
Better use "isolate_" here.
https://codereview.chromium.org/12300018/diff/139/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/12300018/diff/139/src/deoptimizer.h#newcode736
src/deoptimizer.h:736: explicit SlotRef(Isolate* isolate, Object*
literal)
No longer needs to be marked as "explicit" as it has two arguments now.
https://codereview.chromium.org/12300018/diff/139/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/factory.cc#newcode1464
src/factory.cc:1464: return Handle<Object>(obj, isolate());
This can be simplified to "return value ? true_value() : false_value();"
https://codereview.chromium.org/12300018/diff/139/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/hydrogen.cc#newcode7083
src/hydrogen.cc:7083: Representation::Integer32()));
Indentation of third line is off.
https://codereview.chromium.org/12300018/diff/139/src/liveedit.cc
File src/liveedit.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/liveedit.cc#newcode1576
src/liveedit.cc:1576: old_script_object =
Handle<Object>(isolate->heap()->null_value(), isolate);
Just use "old_script_object = isolate->factory()->null_value();" here.
https://codereview.chromium.org/12300018/diff/139/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/objects.cc#newcode1765
src/objects.cc:1765: Handle<Object>(isolate->heap()->undefined_value(),
isolate),
Just use "isolate->factory()->undefined_value()" here.
https://codereview.chromium.org/12300018/diff/139/src/objects.cc#newcode4266
src/objects.cc:4266: Handle<Object>
old_value(isolate->heap()->the_hole_value(), isolate);
Just use "Handle<Object> old_value =
isolate->factory()->the_hole_value();" here.
https://codereview.chromium.org/12300018/diff/139/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/12300018/diff/139/src/runtime.cc#newcode8745
src/runtime.cc:8745: ? GlobalObject::cast(*object)->global_receiver()
Can we indent line three and four here?
https://codereview.chromium.org/12300018/diff/139/src/runtime.cc#newcode10824
src/runtime.cc:10824: ? frame_inspector->GetParameter(i)
Can we indent line two and three here?
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-arm.cc
File test/cctest/test-assembler-arm.cc (right):
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-arm.cc#newcode73
test/cctest/test-assembler-arm.cc:73:
Handle<Object>(isolate->heap()->undefined_value(),
Just use "isolate->factory()->undefined_value()" here and throughout the
rest of this file.
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-ia32.cc
File test/cctest/test-assembler-ia32.cc (right):
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-ia32.cc#newcode76
test/cctest/test-assembler-ia32.cc:76:
Handle<Object>(isolate->heap()->undefined_value(),
Just use "isolate->factory()->undefined_value()" here and throughout the
rest of this file.
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-x64.cc
File test/cctest/test-assembler-x64.cc (right):
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-assembler-x64.cc#newcode433
test/cctest/test-assembler-x64.cc:433:
isolate->heap()->undefined_value(), isolate))->ToObjectChecked());
Just use "isolate->factory()->undefined_value()" here.
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-disasm-ia32.cc
File test/cctest/test-disasm-ia32.cc (right):
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-disasm-ia32.cc#newcode466
test/cctest/test-disasm-ia32.cc:466:
Handle<Object>(isolate->heap()->undefined_value(),
Just use "isolate->factory()->undefined_value()" here.
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-heap.cc#newcode102
test/cctest/test-heap.cc:102: Handle<Object>(heap->undefined_value(),
Just use "isolate->factory()->undefined_value()" here.
https://codereview.chromium.org/12300018/diff/139/test/cctest/test-heap.cc#newcode117
test/cctest/test-heap.cc:117: Handle<Object>(heap->undefined_value(),
... and here.
https://codereview.chromium.org/12300018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
