On 2013/02/25 19:36:03, adamk wrote:
https://codereview.chromium.org/12328064/diff/1/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/12328064/diff/1/src/objects.cc#oldcode3373
src/objects.cc:3373: // Handle [] on String objects.
On 2013/02/25 10:46:25, rossberg wrote:
> I'm not sure removing this is correct. This function is also called by
> GetPropertyAttributeWithReceiver, and on that path, I don't think
strings
would
> be handled otherwise.
I've added a test case covering this case, and it still passes. The
reason is
that, although I've removed the check here, the very next thing this code
does
is call GetElementAttributeWithoutInterceptor, which itself does the
IsStringObjectWithCharacterAt check. Please take a look at the test case
and
see
if there's other stuff that I need to cover.
Hm, I'm not sure what the simplest JS test is then, but I'm pretty certain
that
the following API code will fail after the change:
Handle<String> s = String::New("JS rocks so hard");
ASSERT(s->Has(1));
https://codereview.chromium.org/12328064/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
