Comment #3 on issue 2597 by [email protected]: v8 doesn't detect ARM CPU
features properly in Android sandboxed services.
http://code.google.com/p/v8/issues/detail?id=2597
I feel I'm missing something here. I tried to confirm back in January that
the feature detection did work. I don't remember which Android build I used
then, but here is what I tried today:
I added some "printfs" in platform-linux.cc:
diff --git a/src/platform-linux.cc b/src/platform-linux.cc
index 0359b2d..92d8057 100644
--- a/src/platform-linux.cc
+++ b/src/platform-linux.cc
@@ -111,8 +111,13 @@ static bool CPUInfoContainsString(const char *
search_string) {
FILE* f = NULL;
const char* what = search_string;
- if (NULL == (f = fopen(file_name, "r")))
+ if (NULL == (f = fopen(file_name, "r"))) {
+ OS::PrintError("FAILED TO OPEN /PROC/CPUINFO\n");
return false;
+ } else {
+ OS::PrintError("SUCCESSFULLY OPENED /PROC/CPUINFO\n");
+ }
+
Running a Release-build of Chrome on Android, this is what I see in logcat:
I/ActivityManager( 390): Start proc
com.google.android.apps.chrome:sandboxed_process3 for service
com.google.android.apps.chrome/org.chromium.content.app.SandboxedProcessService3:
pid=2805 uid=99013 gids={}
I/chromium( 2647): [INFO:tab_android_impl.cc(1208)] Starting prerendering
for http://www.facebook.com/
I/ChildProcessService( 2805): Creating new ChildProcessService pid=2805
I/LibraryLoader( 2805): loading: chromeview
D/dalvikvm( 2805): Trying to load lib
/data/app-lib/com.google.android.apps.chrome-1/libchromeview.so 0x41e836d0
D/ChildProcessLauncher( 2647): on connect callback, pid=2805
context=2006263408
D/dalvikvm( 2805): Added shared lib
/data/app-lib/com.google.android.apps.chrome-1/libchromeview.so 0x41e836d0
I/LibraryLoader( 2805): loaded: chromeview
I/chromium( 2805): [INFO:library_loader_hooks.cc(70)] Chromium logging
enabled: level = 0, default verbosity = 0
D/TraceEvent( 2805): New enabled flags: 0
D/dalvikvm( 2805): GC_CONCURRENT freed 180K, 3% free 9049K/9256K, paused
3ms+1ms, total 18ms
E/v8 ( 2805): SUCCESSFULLY OPENED /PROC/CPUINFO
E/v8 ( 2805): SUCCESSFULLY OPENED /PROC/CPUINFO
E/v8 ( 2805): SUCCESSFULLY OPENED /PROC/CPUINFO
E/v8 ( 2805): SUCCESSFULLY OPENED /PROC/CPUINFO
If I read this correctly, 2805 is the sandboxed process and it does open
/proc/cpuinfo, so it seems to be working. What am I missing?
(This was on Android 4.2 JOP40C.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
