https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084
src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native
Client.
On 2013/04/08 16:29:56, Brad Chen wrote:
On 2013/04/08 11:27:10, ulan wrote:
> Is this #ifdef needed because of undefined ucontext_t compile errors
on
> nacl_x64? It might be better to define ucontext_t as we do above for
ANDROID.

No, in this case the problem is more fundamental, that Native Client
doesnt'
support exception handling, which appears to be required for profiling
support.
I will improve the comment.

It might be possible to get this code to compile using the approach used
with ANDROID, but because of the signal handling issues it would not
run. I will change the #ifdef to disable for Native Client on all
platforms. Okay?

https://codereview.chromium.org/13704002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to