LGTM with a few minor comments.
https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py
File tools/testrunner/local/junit_output.py (right):
https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/junit_output.py#newcode32
tools/testrunner/local/junit_output.py:32: class JUnitTestOutput:
nit: This class is small enough that you could just fold its
functionality into JUnitTestProgressIndicator if you wanted. I don't
feel strongly about it either way.
https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/progress.py
File tools/testrunner/local/progress.py (right):
https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/progress.py#newcode32
tools/testrunner/local/progress.py:32: from testrunner.local import
junit_output
nit: please use "from . import junit_output"
https://codereview.chromium.org/13813003/diff/1/tools/testrunner/local/progress.py#newcode273
tools/testrunner/local/progress.py:273: self.outputter.HasRunTest(
nit: suggestion for formatting that better reflects the semantic
structure:
self.outputter.HasRunTest(
[test.GetLabel()] + self.runner.context.mode_flags + test.flags,
test.duration,
fail_text)
https://codereview.chromium.org/13813003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
