OK, I'll hold off with landing til tomorrow, in case you still want to address Arv's comment. I'd be fine with it.
On 15 May 2013 15:52, <a...@chromium.org> wrote: > I see that we are using for-in loops. I just wanted to ask if the order of > these > loops matter? Remember that we iterate over index-like property names first. > Does that screw up the expected order? > > > https://codereview.chromium.org/14779011/diff/25001/src/object-observe.js > File src/object-observe.js (right): > > https://codereview.chromium.org/14779011/diff/25001/src/object-observe.js#newcode195 > src/object-observe.js:195: if (!IS_STRING(arg[i])) > Is this what we really want? Generally the platform just stringifies non > strings. > > https://codereview.chromium.org/14779011/diff/25001/src/object-observe.js#newcode324 > src/object-observe.js:324: if (!IS_STRING(changeType)) > Same here... maybe just String(changeType) as needed. > > https://codereview.chromium.org/14779011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
