https://chromiumcodereview.appspot.com/15735005/diff/4001/src/code-stubs.h
File src/code-stubs.h (right):
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/code-stubs.h#newcode959
src/code-stubs.h:959: // Minor key encoding in 19 bits
TTTRRRLLLSOOOOOOOMM.
Please update this comment.
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/15735005/diff/4001/src/ic.cc#newcode2610
src/ic.cc:2610: (!previous_has_fixed_right_arg ||
I still disagree with this condition, as discussed offline previously.
It should be:
... &&
(previous_overall == BinaryOpIC::UNINITIALIZED ||
(previous_has_fixed_right_arg && previous_fixed_right_arg_value ==
value));
Otherwise you'll go back to assuming a fixed right arg whenever the
right arg happens to be a power of two at a patching event even if
you've seen non-fixed right args before.
https://chromiumcodereview.appspot.com/15735005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
