Hi Hannes, lgtm, though one comment, see if it's addressable.
https://codereview.chromium.org/15734002/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/15734002/diff/8001/src/hydrogen-instructions.h#newcode4878
src/hydrogen-instructions.h:4878: static Flags DefaultFlags() {
It would be nice if these ~20 lines could be shared with the similar
lines in HAllocate. If it is straightforward to make a base class for
those two hydrogen instructions, I would say do it.
https://codereview.chromium.org/15734002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
