lgtm
https://codereview.chromium.org/15898004/diff/1/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/15898004/diff/1/src/object-observe.js#newcode312
src/object-observe.js:312: ObjectFreeze(changeRecord.removed);
On 2013/05/23 22:53:18, rafaelw wrote:
I went back and tried as hard as I could to create a case where
freezing the
removed array impacted the over-all time noticeably -- and failed to
produce
anything that was obviously not in the noise.
I think it's fine to leave this in.
Sounds good to me, thanks for doing the footwork to verify this.
On 2013/05/23 21:12:39, adamk wrote:
> I'd leave this out for now, as it basically doubles the cost of
creating a
> splice record (create the removed array, then create a dictionary
backing
store
> and copy everything over).
https://codereview.chromium.org/15898004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
