LGTM with comments.
https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instructions.h#newcode3402
src/hydrogen-instructions.h:3402: // By default, binary instructions
don't handle Smis.
nit: s/instructions/operations/ for consistency in nomenclature.
https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen-instructions.h#newcode3571
src/hydrogen-instructions.h:3571: Representation r =
Representation::None())
Since you're not using r any more, you can remove it entirely.
https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/15861009/diff/8001/src/hydrogen.cc#newcode1543
src/hydrogen.cc:1543: elements_kind = FAST_HOLEY_ELEMENTS;
nit: this looks a bit surprising, please add a comment, e.g.:
// Since we're about to store the hole value, the store instructions
below
// must assume an elements kind that allows this.
https://chromiumcodereview.appspot.com/15861009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
