Revision: 14902
Author: [email protected]
Date: Fri May 31 04:58:39 2013
Log: Fix non-idempotent modification in JSObject::AddFastProperty.
[email protected]
BUG=mozilla/ecma/Array/15.4.5.2-2
Review URL: https://codereview.chromium.org/15955010
http://code.google.com/p/v8/source/detail?r=14902
Modified:
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/objects.cc Tue May 28 04:23:59 2013
+++ /branches/bleeding_edge/src/objects.cc Fri May 31 04:58:39 2013
@@ -1824,15 +1824,18 @@
Heap* heap = isolate->heap();
- Map* new_map;
- MaybeObject* maybe_new_map = map()->CopyAddDescriptor(&new_field, flag);
- if (!maybe_new_map->To(&new_map)) return maybe_new_map;
-
Object* storage;
MaybeObject* maybe_storage =
value->AllocateNewStorageFor(heap, representation);
if (!maybe_storage->To(&storage)) return maybe_storage;
+ // Note that Map::CopyAddDescriptor has side-effects, the new map is
already
+ // inserted in the transition tree. No more allocations that might fail
are
+ // allowed after this point.
+ Map* new_map;
+ MaybeObject* maybe_new_map = map()->CopyAddDescriptor(&new_field, flag);
+ if (!maybe_new_map->To(&new_map)) return maybe_new_map;
+
if (map()->unused_property_fields() == 0) {
ASSERT(values != NULL);
set_properties(values);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
