Addressed feedback so far, working on the last missing ARM piece...
https://codereview.chromium.org/15735005/diff/26001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/15735005/diff/26001/src/ia32/lithium-codegen-ia32.cc#newcode1272
src/ia32/lithium-codegen-ia32.cc:1272: Comment(";;; modi
has_fixed_right_arg:%d fixed_right_arg_value:%d",
On 2013/06/03 09:49:30, Jakob wrote:
This looks like a debugging leftover.
Done.
https://codereview.chromium.org/15735005/diff/26001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/15735005/diff/26001/src/ic.cc#newcode2575
src/ic.cc:2575: static bool TryToInt32(Handle<Object> object, int32_t*
result) {
On 2013/06/03 09:49:30, Jakob wrote:
In deoptimizer.cc, we have a "static bool ObjectToInt32(Object* obj,
int32_t*
value)", that's almost the same. Can we unify them?
Done: I've moved the conversion routines to int32_t/uint32_t to Object
and reuse them here and in deoptimizer.cc. There are more places which
need some refactoring, but not in this CL...
https://codereview.chromium.org/15735005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
