LGTM with a nit.
https://codereview.chromium.org/16365008/diff/4001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/16365008/diff/4001/include/v8.h#newcode5677
include/v8.h:5677: bool fits_into_int32_t = (i & (1 << 31)) == 0;
I think 'i < INT32_MAX' is more readable than this bit fiddling, and we
even don't need a separate bool for this, as it is self-explaining.
https://codereview.chromium.org/16365008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
