LGTM if comments are addressed.
https://codereview.chromium.org/16147004/diff/3001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/16147004/diff/3001/src/api.cc#newcode4313
src/api.cc:4313: static const uint64_t value = 0xFF00FF00FF00ULL;
Shouldn't this be 0xFF00FF00FF00FF00ULL (missing one FF00)?
Nice to have: test case for this.
https://codereview.chromium.org/16147004/diff/3001/src/api.cc#newcode4315
src/api.cc:4315: static const uintptr_t kOneByteMask =
OneByteMask<sizeof(uintptr_t)>::value;
I guess you could also just
static_cast<uintptr_t>(0xFF00FF00FF00FF00ULL) to get it to the correct
size.
https://codereview.chromium.org/16147004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
