Reviewers: Paul Lind, danno, Toon Verwaest, kisg, kilvadyb,
Description:
MIPS: Implement IC support for Constant Function transitions.
Port r15124 (6b02a945)
BUG=
Please review this at https://codereview.chromium.org/16984002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/stub-cache-mips.cc
Index: src/mips/stub-cache-mips.cc
diff --git a/src/mips/stub-cache-mips.cc b/src/mips/stub-cache-mips.cc
index
6e422422ea6529984c4725e94b8ae15699d1620b..3681120a7d8cd098a2362d7bea2bddeec9eb0515
100644
--- a/src/mips/stub-cache-mips.cc
+++ b/src/mips/stub-cache-mips.cc
@@ -503,7 +503,12 @@ void
StubCompiler::GenerateStoreTransition(MacroAssembler* masm,
Register storage_reg = name_reg;
- if (FLAG_track_fields && representation.IsSmi()) {
+ if (details.type() == CONSTANT_FUNCTION) {
+ Handle<HeapObject> constant(
+ HeapObject::cast(descriptors->GetValue(descriptor)));
+ __ LoadHeapObject(scratch1, constant);
+ __ Branch(miss_restore_name, ne, value_reg, Operand(scratch1));
+ } else if (FLAG_track_fields && representation.IsSmi()) {
__ JumpIfNotSmi(value_reg, miss_restore_name);
} else if (FLAG_track_heap_object_fields &&
representation.IsHeapObject()) {
__ JumpIfSmi(value_reg, miss_restore_name);
@@ -560,6 +565,8 @@ void
StubCompiler::GenerateStoreTransition(MacroAssembler* masm,
OMIT_REMEMBERED_SET,
OMIT_SMI_CHECK);
+ if (details.type() == CONSTANT_FUNCTION) return;
+
int index = transition->instance_descriptors()->GetFieldIndex(
transition->LastAdded());
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
