LGTM with nits.
https://codereview.chromium.org/17167002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/17167002/diff/1/src/runtime.cc#newcode4757
src/runtime.cc:4757: if (!value->IsSmi() && !value->IsHeapNumber() &&
!value->IsUndefined()) {
nit: Better use "!value->IsNumber() && !value->IsUndefined()" here.
https://codereview.chromium.org/17167002/diff/1/src/runtime.cc#newcode4777
src/runtime.cc:4777: !value->IsHeapNumber() &&
nit: Likewise.
https://codereview.chromium.org/17167002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
