This actually leads me to my first high level feedback...
Although the automated porting script is an intriguing idea, I am _very_
hesitant to build this kind of explicit dependency between the x32 and x64
ports. This puts some (much) of the burden of maintaining the x32 port on
the
core V8 team because there will be changes needed to core platform code (x64
annotations) to support keeping the x32 version. Normally, we expect
platform
ports to be limited to changes in the directory of the port and not outside.
Also, your #ifdefs in the x64 port are a red flag. Having compile time
switches
for one port in another port breaks architectural abstraction.
I am also not convinced that all of the x64 annotations are really needed at
all. For example, I could imagine a variant of your approach where there are
macro assembler instructions to encapsulate the "higher-level" operations
that
differ from x64 and x32, e.g. manipulating the return address or
loading/storing
from 64-bit double values.
In any case, I would like to discuss the options with my V8 colleagues to
give
you guidance about how to proceed. If you can be patient for a few days
before
proceeding, our feedback might help you avoid duplicate work.
Regards,
Danno
https://codereview.chromium.org/18014003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
