On 2013/07/08 08:22:33, Benedikt Meurer wrote:
https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h
File src/hydrogen-infer-types.h (right):
https://codereview.chromium.org/18568007/diff/1/src/hydrogen-infer-types.h#newcode48
src/hydrogen-infer-types.h:48: void InitializeInferredTypes(int
from_inclusive,
int to_inclusive);
On 2013/07/08 08:18:50, Dmitry Lomov (chromium) wrote:
> InitializeInferredTypes is misleading, since this is actually the method
that
> does all the work. Let's remove this method and do all the work
directly in
Run.
We need the separate method for the recursive calls.
Ah ok got it, then the comment about fields does not apply too.
Maybe consider renaming InitializeInferredTypes -> InferTypes, but otherwise
lgtm.
https://codereview.chromium.org/18568007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
