Revision: 15557
Author: [email protected]
Date: Mon Jul 8 08:22:12 2013
Log: Fix an implicit cast from int64 to double in the i18n extension
On MSVS, this throws an error
BUG=v8:2745
[email protected]
Review URL: https://codereview.chromium.org/18854002
http://code.google.com/p/v8/source/detail?r=15557
Modified:
/branches/bleeding_edge/src/extensions/i18n/number-format.cc
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/number-format.cc Wed Jul 3
04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/number-format.cc Mon Jul 8
08:22:12 2013
@@ -148,10 +148,10 @@
args.GetReturnValue().Set(result.getDouble());
return;
case icu::Formattable::kLong:
- args.GetReturnValue().Set(v8::Number::New(result.getLong()));
+ args.GetReturnValue().Set(result.getLong());
return;
case icu::Formattable::kInt64:
- args.GetReturnValue().Set(v8::Number::New(result.getInt64()));
+ args.GetReturnValue().Set(static_cast<double>(result.getInt64()));
return;
default:
return;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.