[v8-dev] Re: Enable debug builds with some optimizations turned on. (issue 18516012)

[machenbach]

On 2013/07/09 16:47:07, Jakob wrote:
LGTM with comments.

https://codereview.chromium.org/18516012/diff/4001/build/common.gypi
File build/common.gypi (right):


https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode507
build/common.gypi:507: 'msvs_settings': {
Keeping the msvs_settings section where it was saves two levels of
indentation.
It's safe to have it outside an OS=="win" conditional, since the section  
is
ignored by other GYP generators anyway.
I don't feel strongly about this though.


https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode519
build/common.gypi:519: }]
nit: trailing comma (not necessary for correctness, but we're pretty
consistent
about putting it in nevertheless).


https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode533
build/common.gypi:533: }]
nit: trailing comma


https://codereview.chromium.org/18516012/diff/4001/build/common.gypi#newcode561
build/common.gypi:561: }]
nit: trailing comma
Done. Copied also most of the optimizaions from
https://codereview.chromium.org/18431003/

https://codereview.chromium.org/18516012/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.