Revision: 15762
Author: mstarzin...@chromium.org
Date: Fri Jul 19 01:25:44 2013
Log: Fix %NeverOptimizeFunction runtime call.
The current usage of this runtime function is broken as it does not
prevent inlining of the affected function but rather bails out from the
whole unit of compilation after trying to inline affected functions.
This simplifies said runtime function to avoid accidental misuse.
R=tit...@chromium.org
TEST=mjsunit/never-optimize
Review URL: https://codereview.chromium.org/19776006
http://code.google.com/p/v8/source/detail?r=15762
Modified:
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/src/runtime.cc
/branches/bleeding_edge/src/runtime.h
/branches/bleeding_edge/test/mjsunit/compiler/inline-arguments.js
/branches/bleeding_edge/test/mjsunit/elements-kind.js
/branches/bleeding_edge/test/mjsunit/elide-double-hole-check-9.js
/branches/bleeding_edge/test/mjsunit/generated-transition-stub.js
/branches/bleeding_edge/test/mjsunit/never-optimize.js
/branches/bleeding_edge/test/mjsunit/opt-elements-kind.js
/branches/bleeding_edge/test/mjsunit/osr-elements-kind.js
/branches/bleeding_edge/test/mjsunit/regress/regress-1713b.js
/branches/bleeding_edge/test/mjsunit/regress/regress-97116b.js
/branches/bleeding_edge/test/mjsunit/regress/regress-crbug-173907b.js
/branches/bleeding_edge/test/mjsunit/regress/regress-deopt-gcb.js
/branches/bleeding_edge/test/mjsunit/regress/regress-mul-canoverflowb.js
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Thu Jul 18 02:46:56 2013
+++ /branches/bleeding_edge/src/hydrogen.cc Fri Jul 19 01:25:44 2013
@@ -7378,14 +7378,6 @@
const Runtime::Function* function = expr->function();
ASSERT(function != NULL);
-
- if (static_cast<int>(function->function_id)
- == static_cast<int>(Runtime::kNeverOptimize)
- && expr->arguments()->length() == 0) {
- // %NeverOptimize() without arguments marks the caller as never
optimize.
- return Bailout("function marked itself as never optimize");
- }
-
if (function->intrinsic_type == Runtime::INLINE) {
ASSERT(expr->name()->length() > 0);
ASSERT(expr->name()->Get(0) == '_');
=======================================
--- /branches/bleeding_edge/src/runtime.cc Thu Jul 18 07:00:53 2013
+++ /branches/bleeding_edge/src/runtime.cc Fri Jul 19 01:25:44 2013
@@ -8425,23 +8425,12 @@
}
-RUNTIME_FUNCTION(MaybeObject*, Runtime_NeverOptimize) {
+RUNTIME_FUNCTION(MaybeObject*, Runtime_NeverOptimizeFunction) {
HandleScope scope(isolate);
-
- if (args.length() == 0) {
- // Disable optimization for the calling function.
- JavaScriptFrameIterator it(isolate);
- if (!it.done()) {
- it.frame()->function()->shared()->set_optimization_disabled(true);
- }
- return isolate->heap()->undefined_value();
- }
-
- // Disable optimization for the functions passed.
- for (int i = 0; i < args.length(); i++) {
- CONVERT_ARG_CHECKED(JSFunction, function, i);
- function->shared()->set_optimization_disabled(true);
- }
+ ASSERT(args.length() == 1);
+ CONVERT_ARG_CHECKED(JSFunction, function, 0);
+ ASSERT(!function->IsOptimized());
+ function->shared()->set_optimization_disabled(true);
return isolate->heap()->undefined_value();
}
=======================================
--- /branches/bleeding_edge/src/runtime.h Fri Jul 12 17:20:40 2013
+++ /branches/bleeding_edge/src/runtime.h Fri Jul 19 01:25:44 2013
@@ -97,7 +97,7 @@
F(RunningInSimulator, 0, 1) \
F(IsParallelRecompilationSupported, 0, 1) \
F(OptimizeFunctionOnNextCall, -1, 1) \
- F(NeverOptimize, -1, 1) \
+ F(NeverOptimizeFunction, 1, 1) \
F(CompleteOptimization, 1, 1) \
F(GetOptimizationStatus, 1, 1) \
F(GetOptimizationCount, 1, 1) \
=======================================
--- /branches/bleeding_edge/test/mjsunit/compiler/inline-arguments.js Thu
Jul 11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/compiler/inline-arguments.js Fri
Jul 19 01:25:44 2013
@@ -115,9 +115,9 @@
})();
// Test arguments access from the inlined function.
+%NeverOptimizeFunction(uninlinable);
function uninlinable(v) {
assertEquals(0, v);
- %NeverOptimize();
return 0;
}
=======================================
--- /branches/bleeding_edge/test/mjsunit/elements-kind.js Thu Jul 11
07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/elements-kind.js Fri Jul 19
01:25:44 2013
@@ -170,22 +170,22 @@
monomorphic(smi_only);
if (support_smi_only_arrays) {
+ %NeverOptimizeFunction(construct_smis);
function construct_smis() {
- %NeverOptimize();
var a = [0, 0, 0];
a[0] = 0; // Send the COW array map to the steak house.
assertKind(elements_kind.fast_smi_only, a);
return a;
}
+ %NeverOptimizeFunction(construct_doubles);
function construct_doubles() {
- %NeverOptimize();
var a = construct_smis();
a[0] = 1.5;
assertKind(elements_kind.fast_double, a);
return a;
}
+ %NeverOptimizeFunction(construct_objects);
function construct_objects() {
- %NeverOptimize();
var a = construct_smis();
a[0] = "one";
assertKind(elements_kind.fast, a);
@@ -193,8 +193,8 @@
}
// Test crankshafted transition SMI->DOUBLE.
+ %NeverOptimizeFunction(convert_to_double);
function convert_to_double(array) {
- %NeverOptimize();
array[1] = 2.5;
assertKind(elements_kind.fast_double, array);
assertEquals(2.5, array[1]);
@@ -205,8 +205,8 @@
smis = construct_smis();
convert_to_double(smis);
// Test crankshafted transitions SMI->FAST and DOUBLE->FAST.
+ %NeverOptimizeFunction(convert_to_fast);
function convert_to_fast(array) {
- %NeverOptimize();
array[1] = "two";
assertKind(elements_kind.fast, array);
assertEquals("two", array[1]);
@@ -222,8 +222,8 @@
convert_to_fast(doubles);
// Test transition chain SMI->DOUBLE->FAST (crankshafted function will
// transition to FAST directly).
+ %NeverOptimizeFunction(convert_mixed);
function convert_mixed(array, value, kind) {
- %NeverOptimize();
array[1] = value;
assertKind(kind, array);
assertEquals(value, array[1]);
=======================================
--- /branches/bleeding_edge/test/mjsunit/elide-double-hole-check-9.js Thu
Jul 11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/elide-double-hole-check-9.js Fri
Jul 19 01:25:44 2013
@@ -29,8 +29,8 @@
var do_set = false;
+%NeverOptimizeFunction(set_proto_elements);
function set_proto_elements() {
- %NeverOptimize();
if (do_set) Array.prototype[1] = 1.5;
}
=======================================
--- /branches/bleeding_edge/test/mjsunit/generated-transition-stub.js Thu
Jul 11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/generated-transition-stub.js Fri
Jul 19 01:25:44 2013
@@ -27,192 +27,196 @@
// Flags: --allow-natives-syntax --compiled_transitions
-%NeverOptimize();
+%NeverOptimizeFunction(test);
+function test() {
-var iteration_count = 1;
+ var iteration_count = 1;
-function transition1(a, i, v) {
- a[i] = v;
-}
+ function transition1(a, i, v) {
+ a[i] = v;
+ }
-//
-// Test PACKED SMI -> PACKED DOUBLE
-//
+ //
+ // Test PACKED SMI -> PACKED DOUBLE
+ //
-var a1 = [0, 1, 2, 3, 4];
-transition1(a1, 0, 2.5);
-var a2 = [0, 1, 2, 3, 4];
-transition1(a2, 0, 2.5);
-assertFalse(%HasFastHoleyElements(a2));
-%OptimizeFunctionOnNextCall(transition1);
+ var a1 = [0, 1, 2, 3, 4];
+ transition1(a1, 0, 2.5);
+ var a2 = [0, 1, 2, 3, 4];
+ transition1(a2, 0, 2.5);
+ assertFalse(%HasFastHoleyElements(a2));
+ %OptimizeFunctionOnNextCall(transition1);
-var a3 = [0, 1, 2, 3, 4];
-assertTrue(%HasFastSmiElements(a3));
-transition1(a3, 0, 2.5);
-assertFalse(%HasFastHoleyElements(a3));
-assertEquals(4, a3[4]);
-assertEquals(2.5, a3[0]);
+ var a3 = [0, 1, 2, 3, 4];
+ assertTrue(%HasFastSmiElements(a3));
+ transition1(a3, 0, 2.5);
+ assertFalse(%HasFastHoleyElements(a3));
+ assertEquals(4, a3[4]);
+ assertEquals(2.5, a3[0]);
-// Test handling of hole.
-var a4 = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
-a4.length = 7;
-assertTrue(%HasFastSmiElements(a4));
-transition1(a4, 0, 2.5);
-assertFalse(%HasFastHoleyElements(a4));
-assertEquals(2.5, a4[0]);
-assertEquals(undefined, a4[8]);
+ // Test handling of hole.
+ var a4 = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
+ a4.length = 7;
+ assertTrue(%HasFastSmiElements(a4));
+ transition1(a4, 0, 2.5);
+ assertFalse(%HasFastHoleyElements(a4));
+ assertEquals(2.5, a4[0]);
+ assertEquals(undefined, a4[8]);
-// Large array should deopt to runtimea
-for (j = 0; j < iteration_count; ++j) {
- a5 = new Array();
- for (i = 0; i < 0x40000; ++i) {
- a5[i] = 0;
+ // Large array should deopt to runtimea
+ for (j = 0; j < iteration_count; ++j) {
+ a5 = new Array();
+ for (i = 0; i < 0x40000; ++i) {
+ a5[i] = 0;
+ }
+ assertTrue(%HasFastSmiElements(a5) || %HasFastDoubleElements(a5));
+ transition1(a5, 0, 2.5);
+ assertEquals(2.5, a5[0]);
}
- assertTrue(%HasFastSmiElements(a5) || %HasFastDoubleElements(a5));
- transition1(a5, 0, 2.5);
- assertEquals(2.5, a5[0]);
-}
-//
-// Test HOLEY SMI -> HOLEY DOUBLE
-//
+ //
+ // Test HOLEY SMI -> HOLEY DOUBLE
+ //
-function transition2(a, i, v) {
- a[i] = v;
-}
+ function transition2(a, i, v) {
+ a[i] = v;
+ }
-var b1 = [0, 1, 2, , 4];
-transition2(b1, 0, 2.5);
-var b2 = [0, 1, 2, , 4];
-transition2(b2, 0, 2.5);
-assertTrue(%HasFastHoleyElements(b2));
-%OptimizeFunctionOnNextCall(transition2);
+ var b1 = [0, 1, 2, , 4];
+ transition2(b1, 0, 2.5);
+ var b2 = [0, 1, 2, , 4];
+ transition2(b2, 0, 2.5);
+ assertTrue(%HasFastHoleyElements(b2));
+ %OptimizeFunctionOnNextCall(transition2);
-var b3 = [0, 1, 2, , 4];
-assertTrue(%HasFastSmiElements(b3));
-assertTrue(%HasFastHoleyElements(b3));
-transition2(b3, 0, 2.5);
-assertTrue(%HasFastHoleyElements(b3));
-assertEquals(4, b3[4]);
-assertEquals(2.5, b3[0]);
+ var b3 = [0, 1, 2, , 4];
+ assertTrue(%HasFastSmiElements(b3));
+ assertTrue(%HasFastHoleyElements(b3));
+ transition2(b3, 0, 2.5);
+ assertTrue(%HasFastHoleyElements(b3));
+ assertEquals(4, b3[4]);
+ assertEquals(2.5, b3[0]);
-// Large array should deopt to runtime
-for (j = 0; j < iteration_count; ++j) {
- b4 = [0, ,0];
- for (i = 3; i < 0x40000; ++i) {
- b4[i] = 0;
+ // Large array should deopt to runtime
+ for (j = 0; j < iteration_count; ++j) {
+ b4 = [0, ,0];
+ for (i = 3; i < 0x40000; ++i) {
+ b4[i] = 0;
+ }
+ assertTrue(%HasFastSmiElements(b4));
+ transition2(b4, 0, 2.5);
+ assertEquals(2.5, b4[0]);
}
- assertTrue(%HasFastSmiElements(b4));
- transition2(b4, 0, 2.5);
- assertEquals(2.5, b4[0]);
-}
-//
-// Test PACKED DOUBLE -> PACKED OBJECT
-//
+ //
+ // Test PACKED DOUBLE -> PACKED OBJECT
+ //
-function transition3(a, i, v) {
- a[i] = v;
-}
+ function transition3(a, i, v) {
+ a[i] = v;
+ }
-var c1 = [0, 1, 2, 3.5, 4];
-transition3(c1, 0, new Object());
-var c2 = [0, 1, 2, 3.5, 4];
-transition3(c2, 0, new Object());
-assertTrue(%HasFastObjectElements(c2));
-assertTrue(!%HasFastHoleyElements(c2));
-%OptimizeFunctionOnNextCall(transition3);
+ var c1 = [0, 1, 2, 3.5, 4];
+ transition3(c1, 0, new Object());
+ var c2 = [0, 1, 2, 3.5, 4];
+ transition3(c2, 0, new Object());
+ assertTrue(%HasFastObjectElements(c2));
+ assertTrue(!%HasFastHoleyElements(c2));
+ %OptimizeFunctionOnNextCall(transition3);
-var c3 = [0, 1, 2, 3.5, 4];
-assertTrue(%HasFastDoubleElements(c3));
-assertTrue(!%HasFastHoleyElements(c3));
-transition3(c3, 0, new Array());
-assertTrue(!%HasFastHoleyElements(c3));
-assertTrue(%HasFastObjectElements(c3));
-assertEquals(4, c3[4]);
-assertEquals(0, c3[0].length);
+ var c3 = [0, 1, 2, 3.5, 4];
+ assertTrue(%HasFastDoubleElements(c3));
+ assertTrue(!%HasFastHoleyElements(c3));
+ transition3(c3, 0, new Array());
+ assertTrue(!%HasFastHoleyElements(c3));
+ assertTrue(%HasFastObjectElements(c3));
+ assertEquals(4, c3[4]);
+ assertEquals(0, c3[0].length);
-// Large array under the deopt threshold should be able to trigger GC
without
-// causing crashes.
-for (j = 0; j < iteration_count; ++j) {
- c4 = [0, 2.5, 0];
- for (i = 3; i < 0xa000; ++i) {
- c4[i] = 0;
+ // Large array under the deopt threshold should be able to trigger GC
without
+ // causing crashes.
+ for (j = 0; j < iteration_count; ++j) {
+ c4 = [0, 2.5, 0];
+ for (i = 3; i < 0xa000; ++i) {
+ c4[i] = 0;
+ }
+ assertTrue(%HasFastDoubleElements(c4));
+ assertTrue(!%HasFastHoleyElements(c4));
+ transition3(c4, 0, new Array(5));
+ assertTrue(!%HasFastHoleyElements(c4));
+ assertTrue(%HasFastObjectElements(c4));
+ assertEquals(5, c4[0].length);
}
- assertTrue(%HasFastDoubleElements(c4));
- assertTrue(!%HasFastHoleyElements(c4));
- transition3(c4, 0, new Array(5));
- assertTrue(!%HasFastHoleyElements(c4));
- assertTrue(%HasFastObjectElements(c4));
- assertEquals(5, c4[0].length);
-}
-// Large array should deopt to runtime
-for (j = 0; j < iteration_count; ++j) {
- c5 = [0, 2.5, 0];
- for (i = 3; i < 0x40000; ++i) {
- c5[i] = 0;
+ // Large array should deopt to runtime
+ for (j = 0; j < iteration_count; ++j) {
+ c5 = [0, 2.5, 0];
+ for (i = 3; i < 0x40000; ++i) {
+ c5[i] = 0;
+ }
+ assertTrue(%HasFastDoubleElements(c5));
+ assertTrue(!%HasFastHoleyElements(c5));
+ transition3(c5, 0, new Array(5));
+ assertTrue(!%HasFastHoleyElements(c5));
+ assertTrue(%HasFastObjectElements(c5));
+ assertEquals(5, c5[0].length);
}
- assertTrue(%HasFastDoubleElements(c5));
- assertTrue(!%HasFastHoleyElements(c5));
- transition3(c5, 0, new Array(5));
- assertTrue(!%HasFastHoleyElements(c5));
- assertTrue(%HasFastObjectElements(c5));
- assertEquals(5, c5[0].length);
-}
-//
-// Test HOLEY DOUBLE -> HOLEY OBJECT
-//
+ //
+ // Test HOLEY DOUBLE -> HOLEY OBJECT
+ //
-function transition4(a, i, v) {
- a[i] = v;
-}
+ function transition4(a, i, v) {
+ a[i] = v;
+ }
-var d1 = [0, 1, , 3.5, 4];
-transition4(d1, 0, new Object());
-var d2 = [0, 1, , 3.5, 4];
-transition4(d2, 0, new Object());
-assertTrue(%HasFastObjectElements(d2));
-assertTrue(%HasFastHoleyElements(d2));
-%OptimizeFunctionOnNextCall(transition4);
+ var d1 = [0, 1, , 3.5, 4];
+ transition4(d1, 0, new Object());
+ var d2 = [0, 1, , 3.5, 4];
+ transition4(d2, 0, new Object());
+ assertTrue(%HasFastObjectElements(d2));
+ assertTrue(%HasFastHoleyElements(d2));
+ %OptimizeFunctionOnNextCall(transition4);
-var d3 = [0, 1, , 3.5, 4];
-assertTrue(%HasFastDoubleElements(d3));
-assertTrue(%HasFastHoleyElements(d3));
-transition4(d3, 0, new Array());
-assertTrue(%HasFastHoleyElements(d3));
-assertTrue(%HasFastObjectElements(d3));
-assertEquals(4, d3[4]);
-assertEquals(0, d3[0].length);
+ var d3 = [0, 1, , 3.5, 4];
+ assertTrue(%HasFastDoubleElements(d3));
+ assertTrue(%HasFastHoleyElements(d3));
+ transition4(d3, 0, new Array());
+ assertTrue(%HasFastHoleyElements(d3));
+ assertTrue(%HasFastObjectElements(d3));
+ assertEquals(4, d3[4]);
+ assertEquals(0, d3[0].length);
-// Large array under the deopt threshold should be able to trigger GC
without
-// causing crashes.
-for (j = 0; j < iteration_count; ++j) {
- d4 = [, 2.5, ,];
- for (i = 3; i < 0xa000; ++i) {
- d4[i] = 0;
+ // Large array under the deopt threshold should be able to trigger GC
without
+ // causing crashes.
+ for (j = 0; j < iteration_count; ++j) {
+ d4 = [, 2.5, ,];
+ for (i = 3; i < 0xa000; ++i) {
+ d4[i] = 0;
+ }
+ assertTrue(%HasFastDoubleElements(d4));
+ assertTrue(%HasFastHoleyElements(d4));
+ transition4(d4, 0, new Array(5));
+ assertTrue(%HasFastHoleyElements(d4));
+ assertTrue(%HasFastObjectElements(d4));
+ assertEquals(5, d4[0].length);
+ assertEquals(undefined, d4[2]);
}
- assertTrue(%HasFastDoubleElements(d4));
- assertTrue(%HasFastHoleyElements(d4));
- transition4(d4, 0, new Array(5));
- assertTrue(%HasFastHoleyElements(d4));
- assertTrue(%HasFastObjectElements(d4));
- assertEquals(5, d4[0].length);
- assertEquals(undefined, d4[2]);
-}
-// Large array should deopt to runtime
-for (j = 0; j < iteration_count; ++j) {
- d5 = [, 2.5, ,];
- for (i = 3; i < 0x40000; ++i) {
- d5[i] = 0;
+ // Large array should deopt to runtime
+ for (j = 0; j < iteration_count; ++j) {
+ d5 = [, 2.5, ,];
+ for (i = 3; i < 0x40000; ++i) {
+ d5[i] = 0;
+ }
+ assertTrue(%HasFastDoubleElements(d5));
+ assertTrue(%HasFastHoleyElements(d5));
+ transition4(d5, 0, new Array(5));
+ assertTrue(%HasFastHoleyElements(d5));
+ assertTrue(%HasFastObjectElements(d5));
+ assertEquals(5, d5[0].length);
+ assertEquals(undefined, d5[2]);
}
- assertTrue(%HasFastDoubleElements(d5));
- assertTrue(%HasFastHoleyElements(d5));
- transition4(d5, 0, new Array(5));
- assertTrue(%HasFastHoleyElements(d5));
- assertTrue(%HasFastObjectElements(d5));
- assertEquals(5, d5[0].length);
- assertEquals(undefined, d5[2]);
+
}
+test();
=======================================
--- /branches/bleeding_edge/test/mjsunit/never-optimize.js Thu Jul 11
07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/never-optimize.js Fri Jul 19
01:25:44 2013
@@ -36,21 +36,20 @@
%OptimizeFunctionOnNextCall(o1);
o1();
- // check that the given function was optimized.
+ // Check that the given function was optimized.
var o1_status = %GetOptimizationStatus(o1);
assertTrue(o1_status == 1 // optimized
|| o1_status == 3 // optimized (always opt)
|| o1_status == 5); // lazy recompile requested
- // Test the %NeverOptimize runtime call.
+ // Test the %NeverOptimizeFunction runtime call.
+ %NeverOptimizeFunction(u1);
function u1() {
- %NeverOptimize();
}
function u2() {
+ u1();
}
-
- %NeverOptimize(u2);
u1(); u1();
u2(); u2();
@@ -62,7 +61,6 @@
u2(); u2();
// 2 => not optimized.
- assertEquals(2, %GetOptimizationStatus(u1));
- assertEquals(2, %GetOptimizationStatus(u2));
-
+ assertTrue(%GetOptimizationStatus(u1) == 2);
+ assertFalse(%GetOptimizationStatus(u2) == 2);
}
=======================================
--- /branches/bleeding_edge/test/mjsunit/opt-elements-kind.js Thu Jul 11
07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/opt-elements-kind.js Fri Jul 19
01:25:44 2013
@@ -108,24 +108,24 @@
assertEquals(expected, getKind(obj), name_opt);
}
+%NeverOptimizeFunction(construct_smis);
function construct_smis() {
- %NeverOptimize();
var a = [0, 0, 0];
a[0] = 0; // Send the COW array map to the steak house.
assertKind(elements_kind.fast_smi_only, a);
return a;
}
+%NeverOptimizeFunction(construct_doubles);
function construct_doubles() {
- %NeverOptimize();
var a = construct_smis();
a[0] = 1.5;
assertKind(elements_kind.fast_double, a);
return a;
}
+%NeverOptimizeFunction(convert_mixed);
function convert_mixed(array, value, kind) {
- %NeverOptimize();
array[1] = value;
assertKind(kind, array);
assertEquals(value, array[1]);
=======================================
--- /branches/bleeding_edge/test/mjsunit/osr-elements-kind.js Thu Jul 11
07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/osr-elements-kind.js Fri Jul 19
01:25:44 2013
@@ -109,18 +109,19 @@
}
// long-running loop forces OSR.
+%NeverOptimizeFunction(construct_smis);
+%NeverOptimizeFunction(construct_doubles);
+%NeverOptimizeFunction(convert_mixed);
for (var i = 0; i < 1000000; i++) { }
if (support_smi_only_arrays) {
function construct_smis() {
- %NeverOptimize();
var a = [0, 0, 0];
a[0] = 0; // Send the COW array map to the steak house.
assertKind(elements_kind.fast_smi_only, a);
return a;
}
function construct_doubles() {
- %NeverOptimize();
var a = construct_smis();
a[0] = 1.5;
assertKind(elements_kind.fast_double, a);
@@ -130,7 +131,6 @@
// Test transition chain SMI->DOUBLE->FAST (crankshafted function will
// transition to FAST directly).
function convert_mixed(array, value, kind) {
- %NeverOptimize();
array[1] = value;
assertKind(kind, array);
assertEquals(value, array[1]);
=======================================
--- /branches/bleeding_edge/test/mjsunit/regress/regress-1713b.js Thu Jul
11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-1713b.js Fri Jul
19 01:25:44 2013
@@ -62,6 +62,7 @@
+%NeverOptimizeFunction(Incremental);
function Incremental(O, x) {
if (!x) {
return;
@@ -83,8 +84,6 @@
L.execute(O);
- %NeverOptimize();
-
L = null;
print(">>> 2 <<<");
AllocateXMb(8);
=======================================
--- /branches/bleeding_edge/test/mjsunit/regress/regress-97116b.js Thu Jul
11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-97116b.js Fri Jul
19 01:25:44 2013
@@ -30,8 +30,8 @@
// Check that we are not flushing code for inlined functions that
// have a pending lazy deoptimization on the stack.
+%NeverOptimizeFunction(deopt);
function deopt() {
- %NeverOptimize();
%DeoptimizeFunction(outer);
for (var i = 0; i < 10; i++) gc(); // Force code flushing.
}
=======================================
--- /branches/bleeding_edge/test/mjsunit/regress/regress-crbug-173907b.js
Thu Jul 11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-crbug-173907b.js
Fri Jul 19 01:25:44 2013
@@ -33,8 +33,8 @@
var O = 0;
var result = new Float64Array(2);
+%NeverOptimizeFunction(spill);
function spill() {
- %NeverOptimize();
}
function buggy() {
=======================================
--- /branches/bleeding_edge/test/mjsunit/regress/regress-deopt-gcb.js Thu
Jul 11 07:17:56 2013
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-deopt-gcb.js Fri
Jul 19 01:25:44 2013
@@ -38,9 +38,9 @@
deopt();
}
+// Make sure we don't inline this function
+%NeverOptimizeFunction(deopt);
function deopt() {
- // Make sure we don't inline this function
- %NeverOptimize();
%DeoptimizeFunction(opt_me);
gc();
}
=======================================
---
/branches/bleeding_edge/test/mjsunit/regress/regress-mul-canoverflowb.js
Thu Jul 11 07:17:56 2013
+++
/branches/bleeding_edge/test/mjsunit/regress/regress-mul-canoverflowb.js
Fri Jul 19 01:25:44 2013
@@ -30,8 +30,8 @@
function boom(a) {
return ((a | 0) * (a | 0)) | 0;
}
+%NeverOptimizeFunction(boom_unoptimized);
function boom_unoptimized(a) {
- %NeverOptimize();
return ((a | 0) * (a | 0)) | 0;
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
