Feedback addressed, landed
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc#newcode634
src/x64/code-stubs-x64.cc:634: // to calculate the result if ecx is the
requested return register.
On 2013/07/18 14:54:38, Yang wrote:
comments do not apply to x64 registers
Done.
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc#newcode671
src/x64/code-stubs-x64.cc:671: __ negl(result_reg);
On 2013/07/18 14:54:38, Yang wrote:
We don't do zero-extension while moving anywhere. Could it happen that
the upper
32-bit of the result just carries over?
As discussed, on x64 we ignore the top 32-bits for most operations and
explicitly clear them before we need them if we do.
https://codereview.chromium.org/18333012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
