danno, thanks for the review.
https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (left):
https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#oldcode1447
src/x64/assembler-x64.h:1447: inline void emitq(uint64_t x,
RelocInfo::Mode rmode);
On 2013/07/23 12:40:54, danno wrote:
I don't see a need to remove this. Please leave it in and just add a
new
function.
Done.
https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#newcode1446
src/x64/assembler-x64.h:1446: inline void emit(uintptr_t x,
RelocInfo::Mode rmode);
On 2013/07/23 12:40:54, danno wrote:
why not call this emitp (i.e. for "pointer") and have it take a void*
parameter?
I think that makes it clearer. Then some of the reinterpret_cast
nastiness can
be hidden and centralized inside emitp.
Done.
https://codereview.chromium.org/19752004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
