danno, thanks for the review.
https://codereview.chromium.org/20073004/diff/1/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/20073004/diff/1/src/frames.cc#newcode1525
src/frames.cc:1525: StackHandlerConstants::kSlotCount == 6);
On 2013/07/24 13:28:57, danno wrote:
I think this assert needs to be:
STATIC_ASSERT(StackHandlerConstants::kSlotCount >= 5)
because I think the reason is to ensure that the array indices used
below will
all be valid, but as long as there are 5 or more slots, everything is
OK.
Done.
https://codereview.chromium.org/20073004/diff/1/src/frames.cc#newcode1525
src/frames.cc:1525: StackHandlerConstants::kSlotCount == 6);
On 2013/07/24 13:28:57, danno wrote:
I think this assert needs to be:
STATIC_ASSERT(StackHandlerConstants::kSlotCount >= 5)
because I think the reason is to ensure that the array indices used
below will
all be valid, but as long as there are 5 or more slots, everything is
OK.
Done.
https://codereview.chromium.org/20073004/diff/1/src/frames.cc#newcode1547
src/frames.cc:1547: StackHandlerConstants::kSlotCount == 6);
On 2013/07/24 13:28:57, danno wrote:
See comment above
Done.
https://codereview.chromium.org/20073004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
