Furthermore, with this patch the observed behavior is correct in every way. It is once we implement the @@create hook the current behavior needs to be refined to support subclassing.
I apologize for not including all of this information in the CL description. A better description could have done a lot to reduce peoples immediate concerns. On Thu, Aug 1, 2013 at 12:24 PM, Erik Arvidsson <a...@chromium.org> wrote: > This was agreed at the latest face to face meeting. Shipping the current > behavior, even under an experimental flag, is future hostile. > > > On Thu, Aug 1, 2013 at 12:17 PM, <da...@chromium.org> wrote: > >> NOT lgtm. Why the change for an experimental feature that we don't make >> any >> promises about? This is needless code churn that I see no benefit from. I >> am >> very tempted to roll this back... and in the future please don't don't >> make >> changes to experimental features on purpose that change one incorrect >> behavior >> to another. If you want to change the semantic, please fix it and make it >> spec >> conform. >> >> https://codereview.chromium.**org/21400002/<https://codereview.chromium.org/21400002/> >> > > > > -- > erik > > > -- erik -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
