I rebased with master and ported the Shl for 31-bit-SMI. I introduced a
class
SmiFunctionInvoker to abstract the difference between the FullCodeGen and
LCodeGen. I used it for SmiShiftLeftConstant. I'd like to know your
high-level
feedback before applying it to the other Smi functions (Add, Sub, Mul).
https://codereview.chromium.org/21014003/diff/34001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/21014003/diff/34001/src/x64/lithium-codegen-x64.cc#newcode3529
src/x64/lithium-codegen-x64.cc:3529: void
LCodeGen::EmitSmiMathAbs(LMathAbs* instr) {
Please ignore this part as Weiliang submitted a CL at
https://codereview.chromium.org/22285003/. I include them into this CL
as they get math-abs test case pass for 31 bit smi.
https://codereview.chromium.org/21014003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
