I take back one of my comments ...

https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/22390008/diff/1/src/bootstrapper.cc#newcode1070
src/bootstrapper.cc:1070: global, "ArrayBuffer", JS_ARRAY_BUFFER_TYPE,
On 2013/08/09 15:42:06, Michael Starzinger wrote:
This change should finally make ArrayBuffer.prototype non-writable,
could we add
a separate test file to mjsunit that checks that using something like
the
following:

Object.getOwnPropertyDescriptor(ArrayBuffer, "prototype")

Lets choose a name for the test suite unrelated to typed arrays (e.g.
mjsunit/function-prototype-primordial.js) as this applies to all
experimental
features. Or add it to the mjsunit/function-prototype.js file.

I just realized that this is already covered by mjsunit/builtins.js for
all functions that are inside the snapshot (i.e. not behind a flag).
Please ignore this comment. Sorry for the noise.

https://codereview.chromium.org/22390008/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to