I like this incremental step, please just change where the predicates are
defined as described below and then I think the CL will be ready.
https://chromiumcodereview.appspot.com/22350005/diff/1/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/22350005/diff/1/include/v8.h#newcode5454
include/v8.h:5454: V8_INLINE(static bool SmiValuesAre32Bits()) { return
kApiPointerSize == 8; }
Please put this after "const int kSmiValueSize..." below, and use
kSmiValueSize == 31/32 as the comparison, I think it's a little clearer.
https://chromiumcodereview.appspot.com/22350005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
