On 2013/08/13 10:28:12, Benedikt Meurer wrote:
On 2013/08/13 10:05:20, Yury Semikhatsky wrote:
> https://codereview.chromium.org/22849002/diff/2001/src/circular-queue.cc
> File src/circular-queue.cc (right):
>
>
https://codereview.chromium.org/22849002/diff/2001/src/circular-queue.cc#newcode81
> src/circular-queue.cc:81: MemoryBarrier();
> On 2013/08/13 09:31:32, Benedikt Meurer wrote:
> > Why do we need this memory barrier here?
>
> Because we'd like to see up-to-date value at consumer_pos_->dequeue_pos
and
> Acquire_Load doesn't guarantee that we won't use some cached version of
it.
Right, isn't Release_Load what you need here, assuming that you use
Acquire_Store?
I'm confused which Acquire_Store do you mean? Actually given that we use
memory
barrier here it seems to me that we don't need to use Acquire_/Release_Load
here
at all.
https://codereview.chromium.org/22849002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
