I think PushInt64AsTwoSmis is probably OK, but it's just a little misleading. In
the 31-bit case, you shift the 32nd bit up to the 33rd bit of the 64-bit
register, so it's no longer part of the smi. However, for the purpose of just saving registers that don't look like pointers, I think it will be fine. Just go
ahead with your current approach fo PushInt64AsTwoSmis.

https://codereview.chromium.org/22348005/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to