Although I don't see anything wrong with this patch, I am unclear of the
motivation. Is there a clear performance win by eliminating the eliminating
the
duplicate smi check? Have you tried to quantify the improvement and is it
measurable?
If not, I suspect that having more compact code rather is more important
than
squeezing a cycle or two more out of a loop, especially if it will end up
Crankshafted anyway if it's a performance bottleneck.
https://codereview.chromium.org/22935005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
