https://chromiumcodereview.appspot.com/22152003/diff/35001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://chromiumcodereview.appspot.com/22152003/diff/35001/src/arm/lithium-codegen-arm.cc#newcode2161
src/arm/lithium-codegen-arm.cc:2161: void
LCodeGen::EmitFalseBranch(InstrType instr, Condition cc) {
It would be better to change it above too. If this code get copy/pasted
and the carry clear condition is then used, it will make for a very
tricky bug to find.
On 2013/08/13 15:16:50, Toon Verwaest wrote:
I used the same signature as the function above (EmitBranch). Do you
suggest to
change that as well?
On 2013/08/13 15:08:14, Rodolph Perfetta wrote:
> cc is actually a valid ARM condition code (carry clear) it would be
better to
> use another name.
https://chromiumcodereview.appspot.com/22152003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
