[v8-dev] Remove dead JSReceiver::SetElement method. (issue 22806004)

[mstarzinger]

Reviewers: rossberg,

Description:
Remove dead JSReceiver::SetElement method.
R=rossb...@chromium.org

Please review this at https://codereview.chromium.org/22806004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/objects.h
  M src/objects.cc


Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index  
995ed36f0228b9982dd08f50fc9ef0dd54406b9d..cc7ed0668be8daec0274945db51552ad70f11542  
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -451,17 +451,6 @@ MaybeObject* JSProxy::GetElementWithHandler(Object*  
receiver,
 }


-MaybeObject* JSProxy::SetElementWithHandler(JSReceiver* receiver,
-                                            uint32_t index,
-                                            Object* value,
-                                            StrictModeFlag strict_mode) {
-  String* name;
-  MaybeObject* maybe = GetHeap()->Uint32ToString(index);
-  if (!maybe->To<String>(&name)) return maybe;
-  return SetPropertyWithHandler(receiver, name, value, NONE, strict_mode);
-}
-
-
 bool JSProxy::HasElementWithHandler(uint32_t index) {
   String* name;
   MaybeObject* maybe = GetHeap()->Uint32ToString(index);
@@ -12100,21 +12089,6 @@ MUST_USE_RESULT MaybeObject*  
JSObject::SetFastDoubleElement(
 }


-MaybeObject* JSReceiver::SetElement(uint32_t index,
-                                    Object* value,
-                                    PropertyAttributes attributes,
-                                    StrictModeFlag strict_mode,
-                                    bool check_proto) {
-  if (IsJSProxy()) {
-    return JSProxy::cast(this)->SetElementWithHandler(
-        this, index, value, strict_mode);
-  } else {
-    return JSObject::cast(this)->SetElement(
-        index, value, attributes, strict_mode, check_proto);
-  }
-}
-
-
 Handle<Object> JSObject::SetOwnElement(Handle<JSObject> object,
                                        uint32_t index,
                                        Handle<Object> value,
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index  
f800c5d580eace363c14b94ac947af8cec798fc7..01d9428308c03f80931e13ec098fc57de3beaabb  
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1980,14 +1980,6 @@ class JSReceiver: public HeapObject {
                                       uint32_t index,
                                       DeleteMode mode);

-  // Set the index'th array element.
-  // Can cause GC, or return failure if GC is required.
-  MUST_USE_RESULT MaybeObject* SetElement(uint32_t index,
-                                          Object* value,
-                                          PropertyAttributes attributes,
-                                          StrictModeFlag strict_mode,
-                                          bool check_prototype);
-
   // Tests for the fast common case for property enumeration.
   bool IsSimpleEnum();

@@ -9040,11 +9032,6 @@ class JSProxy: public JSReceiver {
       Object* value,
       PropertyAttributes attributes,
       StrictModeFlag strict_mode);
-  MUST_USE_RESULT MaybeObject* SetElementWithHandler(
-      JSReceiver* receiver,
-      uint32_t index,
-      Object* value,
-      StrictModeFlag strict_mode);

   // If the handler defines an accessor property with a setter, invoke it.
   // If it defines an accessor property without a setter, or a data  
property


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.