LGTM with comments.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393
src/hydrogen-instructions.h:3393: bool SameConstantObject(HConstant*
other) {
This seems to cover a subset of the functionality of DataEquals() below.
Maybe re-use that instead? If you actually need the specialized behavior
then that's fine of course.
https://codereview.chromium.org/22876009/diff/13001/src/lithium.cc
File src/lithium.cc (right):
https://codereview.chromium.org/22876009/diff/13001/src/lithium.cc#newcode512
src/lithium.cc:512: if (graph()->HasUnreachableCode()) {
You can avoid a level of indentation by turning this into an early
return:
if (!graph()->HasUnreachableCode()) return;
https://codereview.chromium.org/22876009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
