lgtm
lgtm
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode4712
src/x64/lithium-codegen-x64.cc:4712: __ jmp(done);
Maybe not in this CL, but I think we can get rid of open jump here if
there is no frame. Can you drop in a TODO to that effect, just to mark
that that is a possibility?
https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/23938003/diff/3001/src/x64/macro-assembler-x64.cc#newcode3064
src/x64/macro-assembler-x64.cc:3064: // If input was positive, we are ok
and return 0, otherwise
"otherwise deoptimize" -> "otherwise goto conversion_failed"
https://codereview.chromium.org/23938003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
