This does not lgtm. It is very unintuitive why Double vs. Int32 representation
would have anything to do with whether operands are better swapped or not.
Probably this benchmark just happens to create a situation where our heuristic
makes the wrong decision. Maybe Better{Left,Right}Operand() should be made
smarter? Changing behavior based on representation does not seem right.

https://codereview.chromium.org/23717039/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to