I'm with Andreas on this. It seems more consistent to allow an empty list. Sure, it doesn't do anything but neither does array.push().
On Wed, Sep 11, 2013 at 9:24 AM, Rafael Weinstein <rafa...@google.com>wrote: > The main motivation is that it is an error. Nothing can be observed if the > acceptList is empty. Would you prefer to silently return? > > Arv? > > > On Wed, Sep 11, 2013 at 3:51 AM, <rossb...@chromium.org> wrote: > >> Is there a strong motivation for disallowing empty accept lists? IME, >> artificial >> discontinuities like that are always a pain when you use an API >> programatically >> (i.e., generate these lists via some generic computation). >> >> >> https://codereview.chromium.**org/23464058/diff/2001/test/** >> mjsunit/harmony/object-**observe.js<https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js> >> File test/mjsunit/harmony/object-**observe.js (right): >> >> https://codereview.chromium.**org/23464058/diff/2001/test/** >> mjsunit/harmony/object-**observe.js#newcode123<https://codereview.chromium.org/23464058/diff/2001/test/mjsunit/harmony/object-observe.js#newcode123> >> test/mjsunit/harmony/object-**observe.js:123: ['foo', 'bar', 'baz'])); >> We should have a test now passing a non-string that actually converts to >> a known accept string. >> >> https://codereview.chromium.**org/23464058/<https://codereview.chromium.org/23464058/> >> > > -- erik -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
