Thanks for having a look!
https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/23620036/diff/5001/src/ia32/stub-cache-ia32.cc#newcode403
src/ia32/stub-cache-ia32.cc:403:
STATIC_ASSERT(PropertyCallbackArguments::kIsolateIndex == -4);
On 2013/09/11 09:55:19, Michael Starzinger wrote:
See comments in stub-cache.cc about these constants.
Done.
https://codereview.chromium.org/23620036/diff/5001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/23620036/diff/5001/src/stub-cache.cc#newcode1283
src/stub-cache.cc:1283: if (PCA::kThisIndex < PCA::kReturnValueOffset)
On 2013/09/11 09:55:19, Michael Starzinger wrote:
Instead of overlaying the indices used for the arguments object here
with PCA,
we should just use a separate set of constant that describes the
layout.
Decouples those two things and avoids this magic "minus 2"
computation. I would
put the index constant into stub-cache.h either at the top-level or
into the
StubCompiler class.
Done.
https://codereview.chromium.org/23620036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
