https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc#newcode1320
src/assembler.cc:1320: Isolate* isolate) {
On 2013/08/28 09:51:32, Hannes Payer wrote:
4 spaces indent
Removed this function as it became redundant after new changes.
https://codereview.chromium.org/22852024/diff/8001/src/assembler.cc#newcode1327
src/assembler.cc:1327: Isolate* isolate) {
On 2013/08/28 09:51:32, Hannes Payer wrote:
4 spaces indent
Done.
https://codereview.chromium.org/22852024/diff/8001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/heap-snapshot-generator.cc#newcode398
src/heap-snapshot-generator.cc:398: void
HeapObjectsMap::MoveObject(Address from, Address to, int object_size) {
On 2013/08/27 09:04:57, loislo wrote:
I think that we need new method UpdateObjectSize and
UpdateObjectSizeEvent in
the heap profiler API
or
we need to change the signature of the method to UpdateObjectInfo.
WDYT?
Done.
https://codereview.chromium.org/22852024/diff/8001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/heap.cc#newcode5040
src/heap.cc:5040:
profiler->NewObjectEvent(HeapObject::cast(clone)->address(),
On 2013/08/27 09:04:57, loislo wrote:
this call actually just updates the size for the object that was
allocated in
the line 4989. I think it could confuse other developers.
So probably we need to call a function that just updates the reported
size.
Done.
https://codereview.chromium.org/22852024/diff/8001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/mark-compact.cc#newcode2929
src/mark-compact.cc:2929: MaybeObject* maybe_result =
target_space->AllocateRawForMigration(object_size);
On 2013/08/27 09:04:57, loislo wrote:
style: 80 symbols
Done.
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc#newcode2317
src/objects.cc:2317: // during GC, and size has to be adjusted
nevetheless.
On 2013/08/27 09:04:57, loislo wrote:
tipo: nevertheless
Done.
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc#newcode2320
src/objects.cc:2320: profiler->NewObjectEvent(elms->address(),
elms->Size());
On 2013/08/27 09:04:57, loislo wrote:
Sounds like we need UpdateObjectSizeEvent method.
Done.
https://codereview.chromium.org/22852024/diff/8001/src/objects.cc#newcode2320
src/objects.cc:2320: profiler->NewObjectEvent(elms->address(),
elms->Size());
On 2013/08/28 09:51:32, Hannes Payer wrote:
yes, an update object size event would be the right thing here.
Done.
https://codereview.chromium.org/22852024/diff/8001/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/22852024/diff/8001/src/serialize.cc#newcode602
src/serialize.cc:602: Add(address, LAZY_DEOPTIMIZATION, 64 + entry,
"lazy_deopt");
On 2013/08/28 09:51:32, Hannes Payer wrote:
64 => 66
Done.
https://codereview.chromium.org/22852024/diff/8001/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/spaces-inl.h#newcode358
src/spaces-inl.h:358: HeapObject* obj =
HeapObject::FromAddress(old_top);
On 2013/08/27 09:04:57, loislo wrote:
Could this line be moved down into the if ("tracking") statement?
I don't think so. Could you please explain why we would want to move it?
Tracking may be switched off but the allocation should be performed I
guess.
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/spaces.h#newcode1702
src/spaces.h:1702: MUST_USE_RESULT inline MaybeObject*
AllocateRawForMigration(int size_in_bytes);
On 2013/08/27 09:04:57, loislo wrote:
style: 80 symbols
Done.
https://codereview.chromium.org/22852024/diff/8001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://codereview.chromium.org/22852024/diff/8001/src/x64/macro-assembler-x64.h#newcode1058
src/x64/macro-assembler-x64.h:1058: int object_size);
On 2013/08/28 09:51:32, Hannes Payer wrote:
Can we move these methods after the Allocate(...) methods and add a
comment.
Done.
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
