LGTM with comments.
https://codereview.chromium.org/24076007/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/24076007/diff/1/src/parser.cc#newcode655
src/parser.cc:655: int beg_pos = scanner().location().beg_pos;
you could just use position() here, right?
https://codereview.chromium.org/24076007/diff/1/src/parser.cc#newcode3261
src/parser.cc:3261: position()); // TODO(rossberg): ???
What does this mean?
https://codereview.chromium.org/24076007/diff/1/src/parser.cc#newcode3297
src/parser.cc:3297: position()); // TODO(rossberg): ???
Ditto.
https://codereview.chromium.org/24076007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
